Ship .pyc and .DS_Store test fixtures in the sdist#646
Merged
audreyfeldroy merged 1 commit intomainfrom Mar 8, 2026
Merged
Conversation
Hatchling excludes .DS_Store via a hardcoded constant and .pyc files via .gitignore's *.py[codz] glob. Both are test fixtures that need to be in the archive. force-include overrides both exclusion mechanisms. Closes #641.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hatchling excludes .DS_Store via a hardcoded constant in
hatchling/builders/constants.pyand .pyc files via.gitignore's
*.py[codz]glob. Both are test fixturesthat need to be in the archive for tests to pass when
run from the sdist.
force-includein pyproject.toml overrides both exclusionmechanisms. A new test builds the sdist and verifies all
four fixtures are present.
Closes #641.
Test plan
test_sdist_includes_pyc_fixturesfails without the fix (red)test_sdist_includes_pyc_fixturespasses with the fix (green)