feat: extract multiple metrics from golang benchmarks#177
Merged
ktrz merged 2 commits intobenchmark-action:masterfrom Jul 7, 2023
Merged
feat: extract multiple metrics from golang benchmarks#177ktrz merged 2 commits intobenchmark-action:masterfrom
ktrz merged 2 commits intobenchmark-action:masterfrom
Conversation
allows go benchmarks to work with extra metrics
9b25b77 to
a669384
Compare
ningziwen
commented
Jul 5, 2023
847788b to
31e8e92
Compare
ktrz
reviewed
Jul 7, 2023
test/extract.spec.ts
Outdated
| expected: [ | ||
| { | ||
| name: 'BenchmarkFib10', | ||
| name: 'BenchmarkFib10 - ns/op', |
Member
There was a problem hiding this comment.
I think this would be a breaking change for all the existing users. I suppose we need to treat the single metric differently and not append anything to the name
Signed-off-by: Ziwen Ning <ningziwe@amazon.com>
ktrz
approved these changes
Jul 7, 2023
Member
ktrz
left a comment
There was a problem hiding this comment.
Thanks for addressing all my comments! LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address the comments of this PR: #119