Fixed getCommitFromGitHubAPIRequest to refer to GITHUB_API_URL#171
Merged
ningziwen merged 3 commits intobenchmark-action:masterfrom May 18, 2023
Merged
Fixed getCommitFromGitHubAPIRequest to refer to GITHUB_API_URL#171ningziwen merged 3 commits intobenchmark-action:masterfrom
ningziwen merged 3 commits intobenchmark-action:masterfrom
Conversation
Contributor
Author
|
This and #169 fix will allow GitHub Enterprise Server and non pull_request events to be used. |
ningziwen
reviewed
May 9, 2023
ningziwen
reviewed
May 15, 2023
srz-zumix
commented
May 16, 2023
ningziwen
reviewed
May 16, 2023
ningziwen
approved these changes
May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getCommitFromGitHubAPIRequest is currently only supported on api.github.com. Therefore, if the event is GitHub Enterprise and the commit cannot be retrieved by payload, it will fail to retrieve the commit.
(e.g. scheduled event)
To fix this, the following fixes have been made.