Skip to content

getServerUrl refers to the GITHUB_SERVER_URL environment variable#169

Merged
ningziwen merged 4 commits intobenchmark-action:masterfrom
srz-zumix:patch-1
May 6, 2023
Merged

getServerUrl refers to the GITHUB_SERVER_URL environment variable#169
ningziwen merged 4 commits intobenchmark-action:masterfrom
srz-zumix:patch-1

Conversation

@srz-zumix
Copy link
Copy Markdown
Contributor

GitHub Enterprise Server 3.7 or earlier fails to resolve the server URL because the schedule event payload does not include repository.

Since the server URL can be got with the GITHUB_SERVER_URL environment variable, it is now referenced if it cannot be got from payload.

https://docs.github.com/en/enterprise-server@3.8/admin/release-notes

For scheduled runs of GitHub Actions workflows, users will see additional information about the repository, organization, and enterprise within the payload for github.event.

Copy link
Copy Markdown
Member

@ningziwen ningziwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ningziwen ningziwen requested a review from ktrz May 3, 2023 07:43
@ningziwen ningziwen merged commit ee5f49d into benchmark-action:master May 6, 2023
@srz-zumix srz-zumix deleted the patch-1 branch May 8, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants