Enable user to specify the git ref being tested#163
Merged
ktrz merged 1 commit intobenchmark-action:masterfrom Apr 26, 2023
Merged
Enable user to specify the git ref being tested#163ktrz merged 1 commit intobenchmark-action:masterfrom
ktrz merged 1 commit intobenchmark-action:masterfrom
Conversation
The ref will be used preferentially (if specified) when looking up the details
of the commit to record the results against.
Why:
When used to record results from a performance test run triggered by a
comment on a PR, the results were recorded against the head commit of main
on our branch. Not the tested commit. This change allows users to specify
the tested ref.
Example usage:
```
with:
ref: refs/pull/${{ github.event.issue.number }}/head
```
ktrz
approved these changes
Apr 26, 2023
Member
ktrz
left a comment
There was a problem hiding this comment.
Thank you for the contribution @robobario!
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ref will be used preferentially (if specified) when looking up the details of the commit to record the results against.
Why:
When used to record results from a performance test run triggered by a comment on a PR, the results were recorded against the head commit of main, not the tested commit. The workflow checked out the PR's ref and ran tests against this. This change allows users to specify the tested ref to record benchmark results against.
Example usage:
Closes #157