Skip to content

Allow more characters in Golang bench outputs#131

Merged
ktrz merged 3 commits intobenchmark-action:masterfrom
vaeryn-uk:master
Apr 26, 2023
Merged

Allow more characters in Golang bench outputs#131
ktrz merged 3 commits intobenchmark-action:masterfrom
vaeryn-uk:master

Conversation

@vaeryn-uk
Copy link
Copy Markdown
Contributor

@vaeryn-uk vaeryn-uk commented Aug 13, 2022

This adds , and = as acceptable characters as Go benchmark names. Previously benchmarks with these character were not detected by this action.

I've run across this problem specifically using table benchmarks, where there are multiple changing variables per benchmark. foo=bar,baz=qux feels like a natural name for these, e.g.

BenchmarkWorldTick/agentCount=1,interactableCount=1,stationary=0,awarenessRange_2000-16                    69483             16465 ns/op
BenchmarkWorldTick/agentCount=20,interactableCount=10,stationary=50,awarenessRange_2000-16                   589           2140095 ns/op
BenchmarkWorldTick/agentCount=200,interactableCount=100,stationary=100,awarenessRange_60-16                  194           5987727 ns/op
BenchmarkWorldTick/agentCount=200,interactableCount=100,stationary=100,awarenessRange_120-16                 174           6981772 ns/op
BenchmarkWorldTick/agentCount=200,interactableCount=100,stationary=100,awarenessRange_240-16                 100          10206439 ns/op
BenchmarkWorldTick/agentCount=1000,interactableCount=100,stationary=100,awarenessRange_30-16                  24          47655071 ns/op

@vaeryn-uk
Allow more characters in Golang bench outputs
b20f84d 
This adds , and = as acceptable characters as Go benchmark names.
Previously benchmarks with these character were not detected by this
action.
matthargett
matthargett approved these changes Apr 15, 2023
View reviewed changes
Copy link
Copy Markdown

@matthargett matthargett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a test! LGTM

ktrz
ktrz approved these changes Apr 26, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@ktrz ktrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @vaeryn-uk!

@ktrz ktrz merged commit 5d67cdc into benchmark-action:master Apr 26, 2023
@ktrz ktrz mentioned this pull request Apr 26, 2023
Closed
@ktrz
Copy link
Copy Markdown
Member

ktrz commented Apr 26, 2023

released in v1.17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktrz ktrz ktrz approved these changes

+1 more reviewer

@matthargett matthargett matthargett approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vaeryn-uk @ktrz @matthargett