Skip to content

refactor: use optional chain for better readability#184

Merged
bcomnes merged 1 commit into
bcomnes:masterfrom
noritaka1166:refactor-code
Jun 9, 2025
Merged

refactor: use optional chain for better readability#184
bcomnes merged 1 commit into
bcomnes:masterfrom
noritaka1166:refactor-code

Conversation

@noritaka1166

@noritaka1166 noritaka1166 commented Jun 7, 2025

Copy link
Copy Markdown
Contributor

use optional chain for better readability

bcomnes
bcomnes approved these changes Jun 9, 2025
View reviewed changes

@bcomnes bcomnes left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, probably left over from an older runtime version range.

@codecov

codecov Bot commented Jun 9, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.03%. Comparing base (74201f5) to head (37a989a).
Report is 22 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   96.14%   96.03%   -0.12%     
==========================================
  Files          35       36       +1     
  Lines        2126     2142      +16     
  Branches        0       84      +84     
==========================================
+ Hits         2044     2057      +13     
- Misses         82       83       +1     
- Partials        0        2       +2
Flag Coverage Δ
macos-latest-20 95.84% <100.00%> (-0.21%) ⬇️
macos-latest-22 95.84% <100.00%> (?)
macos-latest-23 ?
macos-latest-24 95.93% <100.00%> (?)
macos-latest-lts/* ?
ubuntu-latest-20 95.46% <100.00%> (-0.21%) ⬇️
ubuntu-latest-22 95.46% <100.00%> (?)
ubuntu-latest-23 ?
ubuntu-latest-24 95.46% <100.00%> (?)
ubuntu-latest-lts/* ?
windows-latest-20 95.48% <100.00%> (-0.21%) ⬇️
windows-latest-22 95.48% <100.00%> (?)
windows-latest-23 ?
windows-latest-24 95.48% <100.00%> (?)
windows-latest-lts/* ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bcomnes bcomnes merged commit 67fec08 into bcomnes:master Jun 9, 2025
17 checks passed
@noritaka1166 noritaka1166 deleted the refactor-code branch June 9, 2025 16:14
@MatthiasKunnen

MatthiasKunnen commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

Be wary that this PR changes the type from boolean to boolean | undefined. If ?? false were appended, the previous behavior is restored.

Based on the current usage of the isYarn variable, the change will not result in any problems but it is something to take heed of.

@bcomnes

bcomnes commented Nov 11, 2025

Copy link
Copy Markdown
Owner

We're still working in js here so its all goooood maaaan.

@bcomnes

bcomnes commented Nov 11, 2025

Copy link
Copy Markdown
Owner

But good point, random little one-off factors with no 'point' besides updated syntax often have these subtleties that can sometimes bite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcomnes bcomnes bcomnes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@noritaka1166 @MatthiasKunnen @bcomnes