Replace cpu config_setting with constraint_values#394
Merged
Conversation
Using a config_setting based on cpu is deprecated
brentleyjones
previously approved these changes
Mar 28, 2025
I want to test something locally first.
Member
Author
|
@brentleyjones did your testing work |
Collaborator
|
@keith I never got around to testing this yet, sorry. I did a search though and I don't think we are using these constraints, unless they are used implicitly somewhere. |
Member
Author
|
i think you'd have to be using them directly, i don't think we use them internally |
brentleyjones
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a config_setting based on cpu is deprecated