Merged
Conversation
This combines libtool.sh.tpl, libtool_check_unique.cc, xcrunwrapper.sh, and make_hashed_objlist.py into a single C++ driver. This sidesteps issues with our toolchain tools having to discover each other, and reduces some duplication in this setup.
Contributor
|
Is there a reason why not use Swift and SwiftArgumentParser instead of cpp? |
Member
Author
|
There's a bit of a circular dependency problem as this file is required to produce any swift_library. In general the toolchain files are much easier to manage if they're single files. For just swift with no deps vs C++ the downside of using swift is that we're likely more susceptible to having to fight user's Xcode versions. |
aaronsky
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This combines libtool.sh.tpl, libtool_check_unique.cc, xcrunwrapper.sh,
and make_hashed_objlist.py into a single C++ driver.
This sidesteps issues with our toolchain tools having to discover
each other, and reduces some duplication in this setup.