add suppress_warnings feature#367
Merged
aaronsky merged 2 commits intobazelbuild:masterfrom Feb 10, 2025
Merged
Conversation
luispadron
approved these changes
Feb 10, 2025
keith
approved these changes
Feb 10, 2025
Member
keith
left a comment
There was a problem hiding this comment.
seems good to me. i think the only thing to think about with these is where we want to "draw the line" so we don't have a feature per compiler flag. but i totally agree with the benefits of the feature system being easier than passing copts in some cases.
Contributor
Agree! Think this is fine since it's the inverse of an existing feature, but we shouldn't make one for all copts |
Contributor
Author
|
yup, agreed! |
aaronsky
added a commit
to bazelbuild/rules_swift
that referenced
this pull request
Feb 10, 2025
This is something I could use in my codebase. I would like have a way to propagate the `-suppress-warnings` flag to all swift libraries, and specifically, selectively disable it in my REPO.bazel and individual targets. This would allow me to globally suppress warnings for external repositories, without enabling it in my own code, and without needing to juggle the state of the flag setting (`-suppress-warnings` and other diagnostic flags are mutually exclusive afaik). This is the same as how we organize the `swift.warnings_as_errors` feature today. Companion change in apple_support is bazelbuild/apple_support#367
aaronsky
added a commit
to aaronsky/rules_swift
that referenced
this pull request
Feb 11, 2025
This is something I could use in my codebase. I would like have a way to propagate the `-suppress-warnings` flag to all swift libraries, and specifically, selectively disable it in my REPO.bazel and individual targets. This would allow me to globally suppress warnings for external repositories, without enabling it in my own code, and without needing to juggle the state of the flag setting (`-suppress-warnings` and other diagnostic flags are mutually exclusive afaik). This is the same as how we organize the `swift.warnings_as_errors` feature today. Companion change in apple_support is bazelbuild/apple_support#367
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is something I could use in my codebase. I would like have a way to propagate the
-wflag to all clang-using targets, and specifically, selectively disable it in my REPO.bazel and individual targets. This would allow me to globally suppress warnings for external repositories, without enabling it in my own code, and without needing to juggle the state of the flag setting (-wand other diagnostic flags are mutually exclusive afaik). This is the same as how we organize thetreat_warnings_as_errorsfeature today.Companion change in rules_swift is bazelbuild/rules_swift#1489