Use build rules for some toolchain tools#361
Merged
brentleyjones merged 1 commit intomasterfrom Feb 4, 2025
Merged
Conversation
brentleyjones
commented
Feb 4, 2025
6a6e249 to
e775b00
Compare
keith
reviewed
Feb 4, 2025
e775b00 to
d6fe456
Compare
keith
approved these changes
Feb 4, 2025
4923c16 to
c1e10d2
Compare
This causes the tools to be built on the execution platform, which might not be the same as the host platform. This is needed to support cross-platform RBE builds. Signed-off-by: Brentley Jones <github@brentleyjones.com>
c1e10d2 to
54e062b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This causes the tools to be built on the execution platform, which might not be the same as the host platform. This is needed to support cross-platform RBE builds.