Conversation
brentleyjones
approved these changes
Dec 11, 2024
luispadron
approved these changes
Dec 11, 2024
The only thing stopping us from supporting the command line tools was that we always tried to send the Xcode derived environment variables to every action. For the command line tools there are reasonable replacements that should always be safe to hardcode. The only thing weird about this setup is that the target uses the default in bazel which is currently 10.11. It respects --macos_minimum_os, so that's probably fine. In this setup the SDK version is not part of the cache key, users could pass something in the --action_env to solve this if they wanted. That seems hard enough to manage just from the CLT installation side so it probably just doesn't matter for this use case.
8922100 to
f56e82a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only thing stopping us from supporting the command line tools was
that we always tried to send the Xcode derived environment variables to
every action. For the command line tools there are reasonable
replacements that should always be safe to hardcode. The only thing
weird about this setup is that the target uses the default in bazel
which is currently 10.11. It respects --macos_minimum_os, so that's
probably fine.
In this setup the SDK version is not part of the cache key, users could
pass something in the --action_env to solve this if they wanted. That
seems hard enough to manage just from the CLT installation side so it
probably just doesn't matter for this use case.