Skip to content

docs: correct README instructions on no-remote-cache#80

Merged
alexeagle merged 1 commit intobazel-contrib:mainfrom
jmhodges:patch-3
Nov 25, 2025
Merged

docs: correct README instructions on no-remote-cache#80
alexeagle merged 1 commit intobazel-contrib:mainfrom
jmhodges:patch-3

Conversation

@jmhodges
Copy link
Copy Markdown
Contributor

@jmhodges jmhodges commented Nov 6, 2025

The bazel cli flag for the section on improving remote caching is using the name execution_requirements from the parameters of actions, while the actual name for the CLI argument is (unfortunately) modify_execution_info.

Fixes #79

@jmhodges
docs: correct README instructions on no-remote-cache
84f2d5c 
The bazel cli flag for the section on improving remote caching is using the name
`execution_requirements` from the parameters of `actions`, while the actual name
for the CLI argument is (unfortunately) `modify_execution_info`.

Fixes bazel-contrib#79
@aspect-workflows
Copy link
Copy Markdown

aspect-workflows Bot commented Nov 6, 2025 •
edited
Loading

Test (Bazel 7.x) (Test)

All tests were cache hits

24 tests (100.0%) were fully cached saving 2s.

Test (Bazel 8.x) (Test)

All tests were cache hits

24 tests (100.0%) were fully cached saving 2s.

Test (Bazel 9.x) (Test)

All tests were cache hits

24 tests (100.0%) were fully cached saving 2s.

Test (Bazel 7.x) (Test)

e2e/smoke

All tests were cache hits

1 test (100.0%) was fully cached saving 32ms.

Test (Bazel 8.x) (Test)

e2e/smoke

All tests were cache hits

1 test (100.0%) was fully cached saving 63ms.

Test (Bazel 9.x) (Test)

e2e/smoke

All tests were cache hits

1 test (100.0%) was fully cached saving 45ms.

Test (WORKSPACE) (Test)

e2e/smoke

All tests were cache hits

1 test (100.0%) was fully cached saving 59ms.

Test (Bazel 7.x) (Test)

examples

All tests were cache hits

3 tests (100.0%) were fully cached saving 135ms.

Test (Bazel 8.x) (Test)

examples

All tests were cache hits

3 tests (100.0%) were fully cached saving 158ms.

@chatgpt-codex-connector
Copy link
Copy Markdown

chatgpt-codex-connector Bot commented Nov 6, 2025

💡 Codex Review

tar.bzl/tar/private/tar.bzl

Lines 609 to 613 in 84f2d5c

ctx.actions.run_shell(
command = """
{awk} $@ | sort > {out_mtree}
""".format(
awk = ctx.executable._awk.path,

P1 Badge Propagate awk failures in mtree_mutate pipeline

The mutation action now runs {awk} $@ | sort > out_mtree to sort the output. In a shell pipeline, only the exit code of the last command (sort) is observed, so if the awk script exits non‑zero (missing script, syntax error, etc.) the action will still succeed and potentially emit an incomplete mtree. The prior implementation would fail on awk errors. Consider using set -o pipefail or an explicit status check so awk failures still fail the build.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@jmhodges
Copy link
Copy Markdown
Contributor Author

jmhodges commented Nov 6, 2025 •
edited
Loading

That Codex review is baffling. This is a documentation only change. I don't know why it's kicked in or what I can or should do in response to it being wrong

@jmhodges
Copy link
Copy Markdown
Contributor Author

jmhodges commented Nov 23, 2025

Ping!

@jmhodges jmhodges mentioned this pull request Nov 23, 2025
Closed
alexeagle
alexeagle approved these changes Nov 25, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!

@alexeagle alexeagle merged commit 0969f4a into bazel-contrib:main Nov 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

command line argument given in README for Tar and remote caches break in bazel 8.4.2

2 participants

@jmhodges @alexeagle