allow a list of files for repositoryCacheConfig#117
Merged
p0deje merged 2 commits intobazel-contrib:mainfrom Dec 16, 2025
Merged
allow a list of files for repositoryCacheConfig#117p0deje merged 2 commits intobazel-contrib:mainfrom
p0deje merged 2 commits intobazel-contrib:mainfrom
Conversation
kseth
commented
Dec 15, 2025
| core.saveState('google-credentials-path', googleCredentialsPath) | ||
| } | ||
|
|
||
| const externalCacheConfig = yaml.parse(core.getInput('external-cache')) |
Contributor
Author
There was a problem hiding this comment.
I just moved this down here for consistency / legibility but happy to undo.
p0deje
approved these changes
Dec 16, 2025
p0deje
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows a list of files via
repositoryCacheConfigby usingyaml.parseto parse the config. This follows the pattern forexternalCacheConfig.I also updated README.md to have an appropriate example:
Fixes #116
NOTE: This change is backwards incompatible in the multi-line case since previously, the action would look for a single-string file with newlines and markup, but now we parse it into distinct files. I think this is fine since that case was broken anyway.