fix(generator): improve new callee parens check#18046
Merged
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61717 |
|
commit: |
nicolo-ribaudo
approved these changes
Jun 4, 2026
liuxingbaoyu
approved these changes
Jun 4, 2026
JLHwung
commented
Jun 4, 2026
|
|
||
| // The following outer parentheses can be removed | ||
| new f![g()](); | ||
| new (f?.g!.h)(); |
Contributor
Author
There was a problem hiding this comment.
This change reveals another generator bug:
(f?.g!).h should not be printed as f?.g!.h because the optional chain coverage will be changed. I will fix this in a new PR.
JLHwung
added a commit
to JLHwung/babel
that referenced
this pull request
Jun 4, 2026
6 tasks
JLHwung
added a commit
to JLHwung/babel
that referenced
this pull request
Jun 5, 2026
JLHwung
added a commit
to JLHwung/babel
that referenced
this pull request
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we improve the new callee
needsParenslogic: It now covers the tagged template and the TS non-null expressions as well. The recursive call has been replaced by plain loop as well.