Remove corejs exports for @babe/runtime-corejs3#18036
Conversation
| "import": "./helpers/esm/writeOnlyError.js", | ||
| "default": "./helpers/writeOnlyError.js" | ||
| }, | ||
| "./package": "./package.json", |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61696 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61695487cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
commit: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e291ff0126
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56eaed3ad0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
Good catch :) This should really not be needed anymore now that we inject imports directly to core-js-pure.
|
@liuxingbaoyu What type of docs do you think this PR needs? As no Babel 8 version of |
|
Oh, it seems documentation is no longer needed. |
@babel/runtime-corejs3 v8.0.0 removed the core-js re-exports (babel/babel#18036). Drop the corejs:3 option from @babel/plugin-transform-runtime since polyfilling is already handled by @babel/preset-env with useBuiltIns:'usage'. Remove the now- unused @babel/runtime-corejs3 dev dependency. Co-Authored-By: bot_apk <apk@cognition.ai>
Fixes #1, Fixes #2We stopped maintaining this list a long time ago.