fix: ensure targets.esmodules is validated#17770
Merged
JLHwung merged 1 commit intobabel:mainfrom Feb 4, 2026
Merged
Conversation
targets.esmodules is validated
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/60849 |
|
commit: |
liuxingbaoyu
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR ensures that
targets.esmodulesis valid. The typing allows both boolean andintersectbut the runtime validation said otherwise. I will fix the type discrepancies in another PR.As is revealed in the new test case, the
esmodules: truein standalone behaves exactly asesmodules: "intersect", I think this PR suffices to fix the regression.