fix(parser): correctly parse type assertions in extends clause#17761
Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom Jan 31, 2026
Merged
fix(parser): correctly parse type assertions in extends clause#17761nicolo-ribaudo merged 1 commit intobabel:mainfrom
extends clause#17761nicolo-ribaudo merged 1 commit intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/60819 |
|
commit: |
nicolo-ribaudo
pushed a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Jan 31, 2026
JLHwung
pushed a commit
that referenced
this pull request
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where the parser failed to handle TypeScript type assertions (
as,satisfies) inside classextendsclauses, specifically when generics are involved (e.g.,class C extends (B<T> as D) {}).The fix involves:
parseMaybeAssignin the TypeScript plugin to properly handleasandsatisfiesexpressions instead of returning early.parseSubscriptto correctly identify<as the start of generic type arguments even when followed byasorsatisfies, preventing it from incorrectly bailing out to a comparison operator.Tests added for nested generics, array types, and
satisfiesoperator.