Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/60645 |
bcba8aa to
8d3da9f
Compare
| it("param referenced in function body", function () { | ||
| const path = getIdentifierPath("function square(n) { return n * n}"); | ||
| const referencePaths = path.context.scope.bindings.n.referencePaths; | ||
| const referencePaths = path.scope.bindings.n.referencePaths; |
Member
There was a problem hiding this comment.
This is a breaking change right?
Member
Author
There was a problem hiding this comment.
Yes.
We also removed path.visit, but it's no longer working.
|
commit: |
NodePath#visit and NodePath#context
nicolo-ribaudo
approved these changes
Jan 23, 2026
Member
Author
|
We haven't removed |
NodePath#visit and NodePath#contextNodePath#visit
Member
|
Oh this needs a rebase already |
8d3da9f to
05b82fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2