fix(parser): improve super type argument parsing#17720
Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom Jan 27, 2026
Merged
fix(parser): improve super type argument parsing#17720nicolo-ribaudo merged 1 commit intobabel:mainfrom
nicolo-ribaudo merged 1 commit intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/60627 |
|
commit: |
nicolo-ribaudo
approved these changes
Jan 23, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we explode
TSInstantiateExpressionintosuperClassandsuperTypeArgumentwhen it is seen in the heritage clause. The comments are preserved because theTSInstantiateExpressionnode is essentially removed from the AST.It is impossible to tell whether we should exit early when we see
{after type arguments: It can indicate either the start of class body, or the start of a new block statement. Therefore we have to manipulate the AST instead.