Allow Babel 8 in compatible Babel 7 plugins#17580
Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom Nov 25, 2025
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/60141 |
|
commit: |
JLHwung
reviewed
Nov 3, 2025
|
|
||
| export default declare((api, { deprecatedAssertSyntax }: Options) => { | ||
| api.assertVersion(REQUIRED_VERSION("^7.22.0")); | ||
| api.assertVersion(REQUIRED_VERSION("^7.22.0 || ^8.0.0-0")); |
Contributor
There was a problem hiding this comment.
I think this plugin should be kept Babel 7 only. We should remove the deprecatedImportAssert parser plugin in Babel 8 and then archive this syntax plugin.
Member
Author
There was a problem hiding this comment.
Babel 7's preset-env enables this plugin. I'd like to keep it as working (but effectively a no-op) in Babel 8 so that we keep compat with preset-env (at least, when compiling just up to a couple years back of features).
JLHwung
approved these changes
Nov 24, 2025
liuxingbaoyu
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2This is the list of plugins from https://github.com/babel/babel/blob/main/test/babel-7-8-compat/data.json, for which we are testing Babel 8 compatibility, as well as all the syntax plugins.
This PR only affects Babel 7 plugins. Babel 8 plugins still require a Babel 8 version.