perf: Use lighter traversal for jsx __source,__self#17555
Merged
nicolo-ribaudo merged 3 commits intobabel:mainfrom Oct 24, 2025
Merged
perf: Use lighter traversal for jsx __source,__self#17555nicolo-ribaudo merged 3 commits intobabel:mainfrom
__source,__self#17555nicolo-ribaudo merged 3 commits intobabel:mainfrom
Conversation
__source,__self
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/60110 |
|
commit: |
JLHwung
approved these changes
Oct 23, 2025
| ObjectExpression, | ||
| Program, | ||
| } from "@babel/types"; | ||
| import { traverse } from "@babel/types"; |
Contributor
There was a problem hiding this comment.
Nit: Since we already imported types from @babel/core, can we use t.traverse or t.traverseFast instead?
nicolo-ribaudo
approved these changes
Oct 23, 2025
Comment on lines
+316
to
+320
| return template.expression.ast`{ | ||
| fileName: ${fileNameIdentifier}, | ||
| lineNumber: ${fileLineLiteral}, | ||
| columnNumber: ${fileColumnLiteral}, | ||
| }`; |
Member
There was a problem hiding this comment.
Nit: could you indent this? :)
JLHwung
approved these changes
Oct 24, 2025
JLHwung
reviewed
Nov 20, 2025
| if (!t.isJSXOpeningElement(node)) { | ||
| return; | ||
| } | ||
| set.add(node); |
Contributor
There was a problem hiding this comment.
The node was added to a set here but we are missing the set.has(node) usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2