Skip to content

Add attributes to import/export builder#17423

Merged
nicolo-ribaudo merged 3 commits intobabel:mainfrom
JLHwung:add-attributes-import-declaration-builder
Jan 29, 2026
Merged

Add attributes to import/export builder#17423
nicolo-ribaudo merged 3 commits intobabel:mainfrom
JLHwung:add-attributes-import-declaration-builder

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 2, 2025

Q                       A
Fixed Issues? Added attributes to the builder signature of importDeclaration, exportAllDeclaration and exportNamedDeclaration
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

In this PR we add attributes to the builder signature of importDeclaration, exportAllDeclaration and exportNamedDeclaration as the import attributes are part of ES2025 and most modern engines have already migrated from assertions to attributes.

@JLHwung JLHwung added the PR: New Feature 🚀 A type of pull request used for our changelog categories label Jul 2, 2025
@babel-bot
Copy link
Collaborator

babel-bot commented Jul 2, 2025

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/60742

@JLHwung JLHwung added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Jul 21, 2025
@JLHwung JLHwung force-pushed the add-attributes-import-declaration-builder branch from 797fe9b to a5ff929 Compare January 29, 2026 15:53
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 29, 2026

Open in StackBlitz

commit: a5ff929

@nicolo-ribaudo nicolo-ribaudo merged commit c1b31f5 into babel:main Jan 29, 2026
54 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the add-attributes-import-declaration-builder branch January 29, 2026 17:29
@nicolo-ribaudo nicolo-ribaudo added PR: New Feature (next major) 🚀 A type of pull request used for our changelog categories for next major release and removed PR: New Feature 🚀 A type of pull request used for our changelog categories labels Jan 29, 2026
@nicolo-ribaudo nicolo-ribaudo added the PR: New Feature 🚀 A type of pull request used for our changelog categories label Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

7.x: needs backport pkg: types PR: New Feature (next major) 🚀 A type of pull request used for our changelog categories for next major release PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants