[estree] Unify method type parameters handling#17045
Merged
JLHwung merged 2 commits intobabel:mainfrom Jan 10, 2025
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58531 |
liuxingbaoyu
approved these changes
Jan 7, 2025
11 tasks
nicolo-ribaudo
approved these changes
Jan 10, 2025
laine-hallot
pushed a commit
to laine-hallot/uwu-parser
that referenced
this pull request
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we move the typeParameters handling to the
parseMethodroutine so that the type parameters of an object method is also covered. Previously we only handled class methods and overlooked object methods.Given that the Babel 7 eslint-parser has never officially supported typescript-eslint, I think the impact of this change is minimal and thus could be shipped in a patch or minor release.