Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56646 |
Contributor
Author
liuxingbaoyu
approved these changes
Apr 2, 2024
nicolo-ribaudo
approved these changes
Apr 3, 2024
Member
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
I would also be ok with releasing this PR with the prettier tests failing (and then it would be easier for Prettier maintainers to just update Babel and see exactly what they need to change to make tests pass)
Contributor
|
Will fix the test in prettier/prettier#16130 |
This was referenced May 18, 2024
This was referenced May 20, 2024
This was referenced Jul 2, 2024
This was referenced Jul 3, 2024
Open
This was referenced Jul 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per spec 14.3.1.1, it is an early error if a using declaration has no initializer, so we should reject such production in the parser.
New test cases are added. Some of current test cases are modified so that they can throw expected errors.