fix: Correctly generate TSMappedType#16394
Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom Apr 1, 2024
Merged
Conversation
Member
liuxingbaoyu
commented
Mar 29, 2024
| Q | A |
|---|---|
| Fixed Issues? | Fixes #16393 |
| Patch: Bug Fix? | √ |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | √ |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56592 |
nicolo-ribaudo
approved these changes
Mar 29, 2024
JLHwung
approved these changes
Apr 1, 2024
|
@liuxingbaoyu Thank you for the swift fix! type Foo2 = { [key in Bar]? };
type Foo3 = { [key in keyof Bar]-? };
type Foo4 = { [key in keyof Bar]+? }; |
Member
Author
|
You are right, thank you! I will open a new PR. |
Member
|
Ugh, til that's valid TS 😬 |
This was referenced May 18, 2024
This was referenced May 20, 2024
This was referenced Jun 29, 2024
This was referenced Jun 29, 2024
Open
This was referenced Jun 30, 2024
This was referenced Jul 1, 2024
This was referenced Jul 1, 2024
This was referenced Jul 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.