fix: Transform scoping for for X in loop#16384
Merged
JLHwung merged 2 commits intobabel:mainfrom Mar 27, 2024
Merged
Conversation
Member
liuxingbaoyu
commented
Mar 25, 2024
| Q | A |
|---|---|
| Fixed Issues? | Fixes #16382 |
| Patch: Bug Fix? | √ |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | √ |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56574 |
| } | ||
| } | ||
|
|
||
| function w2() { |
Member
There was a problem hiding this comment.
What is the difference between these two functions?
Member
Author
There was a problem hiding this comment.
One is for in and the other is for of. :)
Member
There was a problem hiding this comment.
Ohh I played the "find the difference between the two pictures" game for like 3 minutes before giving up 😬
| assign.length === 1 ? assign[0] : t.sequenceExpression(assign); | ||
| if ( | ||
| !t.isForStatement(varPath.parent, { init: varPath.node }) && | ||
| !t.isForXStatement(varPath.parent, { left: varPath.node }) |
Member
There was a problem hiding this comment.
Can you also add a test swapping the for ... in and for (;;) loops?
forX in loopfor X in loop
nicolo-ribaudo
approved these changes
Mar 25, 2024
JLHwung
approved these changes
Mar 27, 2024
This was referenced May 18, 2024
This was referenced May 20, 2024
This was referenced Jul 2, 2024
This was referenced Jul 3, 2024
Open
This was referenced Jul 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.