Fix the support of `arguments` in private `get/set` method by liuxingbaoyu · Pull Request #16307 · babel/babel

liuxingbaoyu · 2024-02-27T14:09:39Z

Q	A
Fixed Issues?	`Fixes #1, Fixes #2`
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?
License	MIT

Ref: #16299

In this case, the output becomes worse, but this should be rare.
We can still reduce some outputs by passing the this as a parameter.

babel-bot · 2024-02-27T14:11:36Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56356

nicolo-ribaudo

As an alternative, could we avoid wrapping the function and instead rewrite arguments usage?

arguments[(expr)] -> arguments[1 + (expr)]
arguments.length -> arguments.length - 1
Any other usage of arguments -> add var _arguments = [].slice.call(arguments, 1) at the beginning of the fn, and replace arguments with _arguments.

packages/babel-helpers/src/helpers/curryThis.ts

+export default function _curryThis(fn: Function) {
+  return function (thisArg: any) {
+    return fn.apply(thisArg, [].slice.call(arguments, 1));
+  };
+}


packages/babel-plugin-transform-private-methods/test/fixtures/accessors/arguments/exec.js

nicolo-ribaudo · 2024-02-27T14:22:16Z

packages/babel-plugin-transform-private-methods/test/fixtures/accessors/arguments/input.js

+  }
+
+  get #privateFieldValue() {
+    return this.#privateField;


Use arguments somewhere here maybe, to show the outputs for getters too.

…accessors/arguments/exec.js Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

liuxingbaoyu · 2024-02-27T15:00:26Z

I implemented the third situation because the other two seemingly rare and may affect readability.
(The third is implemented simple and easy to test :) 😉)

* fix arguments * Update packages/babel-plugin-transform-private-methods/test/fixtures/accessors/arguments/exec.js Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com> * review * fix types --------- Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@babel/traverse](https://babel.dev/docs/en/next/babel-traverse) ([source](https://github.com/babel/babel)) | resolutions | minor | [`7.23.9` -> `7.24.1`](https://renovatebot.com/diffs/npm/@babel%2ftraverse/7.23.9/7.24.1) | --- ### Release Notes <details> <summary>babel/babel (@babel/traverse)</summary> ### [`v7.24.1`](https://github.com/babel/babel/blob/HEAD/CHANGELOG.md#v7241-2024-03-19) [Compare Source](babel/babel@v7.24.0...v7.24.1) ##### 🐛 Bug Fix - `babel-helper-create-class-features-plugin`, `babel-plugin-proposal-decorators` - [#16350](babel/babel#16350) Fix decorated class computed keys ordering ([@JLHwung](https://github.com/JLHwung)) - [#16344](babel/babel#16344) Fix decorated class static field private access ([@JLHwung](https://github.com/JLHwung)) - `babel-plugin-proposal-decorators`, `babel-plugin-proposal-json-modules`, `babel-plugin-transform-async-generator-functions`, `babel-plugin-transform-regenerator`, `babel-plugin-transform-runtime`, `babel-preset-env` - [#16329](babel/babel#16329) Respect `moduleName` for `@babel/runtime/regenerator` imports ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-helper-create-class-features-plugin`, `babel-plugin-proposal-decorators`, `babel-plugin-proposal-pipeline-operator`, `babel-plugin-transform-class-properties` - [#16331](babel/babel#16331) Fix decorator memoiser binding kind ([@JLHwung](https://github.com/JLHwung)) - `babel-helper-create-class-features-plugin`, `babel-helper-replace-supers`, `babel-plugin-proposal-decorators`, `babel-plugin-transform-class-properties` - [#16325](babel/babel#16325) Fix decorator evaluation private environment ([@JLHwung](https://github.com/JLHwung)) ##### 📝 Documentation - [#16319](babel/babel#16319) Update SECURITY.md ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) ##### 🏠 Internal - `babel-code-frame`, `babel-highlight` - [#16359](babel/babel#16359) Replace `chalk` with `picocolors` ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-helper-fixtures`, `babel-helpers`, `babel-plugin-bugfix-safari-id-destructuring-collision-in-function-expression`, `babel-plugin-proposal-pipeline-operator`, `babel-plugin-transform-unicode-sets-regex`, `babel-preset-env`, `babel-preset-flow` - [#16352](babel/babel#16352) Run Babel transform tests on old node if possible ([@JLHwung](https://github.com/JLHwung)) - `babel-helpers`, `babel-plugin-transform-async-generator-functions`, `babel-plugin-transform-class-properties`, `babel-plugin-transform-class-static-block`, `babel-plugin-transform-modules-commonjs`, `babel-plugin-transform-modules-systemjs`, `babel-plugin-transform-regenerator`, `babel-plugin-transform-runtime`, `babel-preset-env`, `babel-runtime-corejs3`, `babel-runtime`, `babel-standalone` - [#16323](babel/babel#16323) Allow separate helpers to be excluded in Babel 8 ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-helper-module-imports`, `babel-plugin-proposal-import-wasm-source`, `babel-plugin-proposal-json-modules`, `babel-plugin-proposal-record-and-tuple`, `babel-plugin-transform-react-jsx-development`, `babel-plugin-transform-react-jsx` - [#16349](babel/babel#16349) Support merging imports in import injector ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-helper-create-class-features-plugin`, `babel-plugin-bugfix-safari-id-destructuring-collision-in-function-expression`, `babel-plugin-bugfix-v8-spread-parameters-in-optional-chaining`, `babel-plugin-bugfix-v8-static-class-fields-redefine-readonly`, `babel-plugin-external-helpers`, `babel-plugin-proposal-async-do-expressions`, `babel-plugin-proposal-decorators`, `babel-plugin-proposal-destructuring-private`, `babel-plugin-proposal-do-expressions`, `babel-plugin-proposal-duplicate-named-capturing-groups-regex`, `babel-plugin-proposal-explicit-resource-management`, `babel-plugin-proposal-export-default-from`, `babel-plugin-proposal-function-bind`, `babel-plugin-proposal-function-sent`, `babel-plugin-proposal-import-attributes-to-assertions`, `babel-plugin-proposal-import-defer`, `babel-plugin-proposal-import-wasm-source`, `babel-plugin-proposal-json-modules`, `babel-plugin-proposal-optional-chaining-assign`, `babel-plugin-proposal-partial-application`, `babel-plugin-proposal-pipeline-operator`, `babel-plugin-proposal-record-and-tuple`, `babel-plugin-proposal-regexp-modifiers`, `babel-plugin-proposal-throw-expressions`, `babel-plugin-syntax-async-do-expressions`, `babel-plugin-syntax-decimal`, `babel-plugin-syntax-decorators`, `babel-plugin-syntax-destructuring-private`, `babel-plugin-syntax-do-expressions`, `babel-plugin-syntax-explicit-resource-management`, `babel-plugin-syntax-export-default-from`, `babel-plugin-syntax-flow`, `babel-plugin-syntax-function-bind`, `babel-plugin-syntax-function-sent`, `babel-plugin-syntax-import-assertions`, `babel-plugin-syntax-import-attributes`, `babel-plugin-syntax-import-defer`, `babel-plugin-syntax-import-reflection`, `babel-plugin-syntax-import-source`, `babel-plugin-syntax-jsx`, `babel-plugin-syntax-module-blocks`, `babel-plugin-syntax-optional-chaining-assign`, `babel-plugin-syntax-partial-application`, `babel-plugin-syntax-pipeline-operator`, `babel-plugin-syntax-record-and-tuple`, `babel-plugin-syntax-throw-expressions`, `babel-plugin-syntax-typescript`, `babel-plugin-transform-arrow-functions`, `babel-plugin-transform-async-generator-functions`, `babel-plugin-transform-async-to-generator`, `babel-plugin-transform-block-scoped-functions`, `babel-plugin-transform-block-scoping`, `babel-plugin-transform-class-properties`, `babel-plugin-transform-class-static-block`, `babel-plugin-transform-classes`, `babel-plugin-transform-computed-properties`, `babel-plugin-transform-destructuring`, `babel-plugin-transform-dotall-regex`, `babel-plugin-transform-duplicate-keys`, `babel-plugin-transform-dynamic-import`, `babel-plugin-transform-exponentiation-operator`, `babel-plugin-transform-export-namespace-from`, `babel-plugin-transform-flow-comments`, `babel-plugin-transform-flow-strip-types`, `babel-plugin-transform-for-of`, `babel-plugin-transform-function-name`, `babel-plugin-transform-instanceof`, `babel-plugin-transform-jscript`, `babel-plugin-transform-json-strings`, `babel-plugin-transform-literals`, `babel-plugin-transform-logical-assignment-operators`, `babel-plugin-transform-member-expression-literals`, `babel-plugin-transform-modules-amd`, `babel-plugin-transform-modules-commonjs`, `babel-plugin-transform-modules-systemjs`, `babel-plugin-transform-modules-umd`, `babel-plugin-transform-new-target`, `babel-plugin-transform-nullish-coalescing-operator`, `babel-plugin-transform-numeric-separator`, `babel-plugin-transform-object-assign`, `babel-plugin-transform-object-rest-spread`, `babel-plugin-transform-object-set-prototype-of-to-assign`, `babel-plugin-transform-object-super`, `babel-plugin-transform-optional-catch-binding`, `babel-plugin-transform-optional-chaining`, `babel-plugin-transform-parameters`, `babel-plugin-transform-private-methods`, `babel-plugin-transform-private-property-in-object`, `babel-plugin-transform-property-literals`, `babel-plugin-transform-property-mutators`, `babel-plugin-transform-proto-to-assign`, `babel-plugin-transform-react-constant-elements`, `babel-plugin-transform-react-display-name`, `babel-plugin-transform-react-inline-elements`, `babel-plugin-transform-react-jsx-compat`, `babel-plugin-transform-react-jsx-self`, `babel-plugin-transform-react-jsx-source`, `babel-plugin-transform-react-pure-annotations`, `babel-plugin-transform-regenerator`, `babel-plugin-transform-reserved-words`, `babel-plugin-transform-runtime`, `babel-plugin-transform-shorthand-properties`, `babel-plugin-transform-spread`, `babel-plugin-transform-sticky-regex`, `babel-plugin-transform-strict-mode`, `babel-plugin-transform-template-literals`, `babel-plugin-transform-typeof-symbol`, `babel-plugin-transform-typescript`, `babel-plugin-transform-unicode-escapes`, `babel-plugin-transform-unicode-property-regex`, `babel-plugin-transform-unicode-regex`, `babel-plugin-transform-unicode-sets-regex`, `babel-preset-env`, `babel-preset-flow`, `babel-preset-react`, `babel-preset-typescript` - [#16332](babel/babel#16332) Test Babel 7 plugins compatibility with Babel 8 core ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-compat-data`, `babel-plugin-transform-object-rest-spread`, `babel-preset-env` - [#16318](babel/babel#16318) \[babel 8] Fix `@babel/compat-data` package.json ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) ##### 🔬 Output optimization - `babel-helper-replace-supers`, `babel-plugin-transform-class-properties`, `babel-plugin-transform-classes`, `babel-plugin-transform-parameters`, `babel-plugin-transform-runtime` - [#16345](babel/babel#16345) Optimize the use of `assertThisInitialized` after `super()` ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-plugin-transform-class-properties`, `babel-plugin-transform-classes` - [#16343](babel/babel#16343) Use simpler `assertThisInitialized` more often ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-plugin-proposal-decorators`, `babel-plugin-transform-class-properties`, `babel-plugin-transform-object-rest-spread`, `babel-traverse` - [#16342](babel/babel#16342) Consider well-known and registered symbols as literals ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-core`, `babel-plugin-external-helpers`, `babel-plugin-proposal-decorators`, `babel-plugin-proposal-function-bind`, `babel-plugin-transform-class-properties`, `babel-plugin-transform-classes`, `babel-plugin-transform-flow-comments`, `babel-plugin-transform-flow-strip-types`, `babel-plugin-transform-function-name`, `babel-plugin-transform-modules-systemjs`, `babel-plugin-transform-parameters`, `babel-plugin-transform-private-property-in-object`, `babel-plugin-transform-react-jsx`, `babel-plugin-transform-runtime`, `babel-plugin-transform-spread`, `babel-plugin-transform-typescript`, `babel-preset-env` - [#16326](babel/babel#16326) Reduce the use of class names ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) ### [`v7.24.0`](https://github.com/babel/babel/blob/HEAD/CHANGELOG.md#v7240-2024-02-28) [Compare Source](babel/babel@v7.23.9...v7.24.0) ##### 🚀 New Feature - `babel-standalone` - [#11696](babel/babel#11696) Export babel tooling packages in `@babel/standalone` ([@ajihyf](https://github.com/ajihyf)) - `babel-core`, `babel-helper-create-class-features-plugin`, `babel-helpers`, `babel-plugin-transform-class-properties` - [#16267](babel/babel#16267) Implement `noUninitializedPrivateFieldAccess` assumption ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-helper-create-class-features-plugin`, `babel-helpers`, `babel-plugin-proposal-decorators`, `babel-plugin-proposal-pipeline-operator`, `babel-plugin-syntax-decorators`, `babel-plugin-transform-class-properties`, `babel-runtime-corejs2`, `babel-runtime-corejs3`, `babel-runtime` - [#16242](babel/babel#16242) Support decorator 2023-11 normative updates ([@JLHwung](https://github.com/JLHwung)) - `babel-preset-flow` - [#16309](babel/babel#16309) \[babel 7] Allow setting `ignoreExtensions` in Flow preset ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - [#16284](babel/babel#16284) Add `experimental_useHermesParser` option in `preset-flow` ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-helper-import-to-platform-api`, `babel-plugin-proposal-import-wasm-source`, `babel-plugin-proposal-json-modules`, `babel-standalone` - [#16172](babel/babel#16172) Add transform support for JSON modules imports ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-plugin-transform-runtime` - [#16241](babel/babel#16241) Add back `moduleName` option to `@babel/plugin-transform-runtime` ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-parser`, `babel-types` - [#16277](babel/babel#16277) Allow import attributes for `TSImportType` ([@sosukesuzuki](https://github.com/sosukesuzuki)) ##### 🐛 Bug Fix - `babel-plugin-proposal-do-expressions`, `babel-traverse` - [#16305](babel/babel#16305) fix: avoid `popContext` on unvisited node paths ([@JLHwung](https://github.com/JLHwung)) - `babel-helper-create-class-features-plugin`, `babel-plugin-transform-private-methods`, `babel-plugin-transform-private-property-in-object` - [#16312](babel/babel#16312) Fix class private properties when `privateFieldsAsSymbols` ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-helper-create-class-features-plugin`, `babel-plugin-transform-private-methods` - [#16307](babel/babel#16307) Fix the support of `arguments` in private `get/set` method ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-helper-create-class-features-plugin`, `babel-helpers`, `babel-plugin-proposal-decorators` - [#16287](babel/babel#16287) Reduce decorator static property size ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-helper-create-class-features-plugin`, `babel-plugin-proposal-decorators` - [#16281](babel/babel#16281) Fix evaluation order of decorators with cached receiver ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - [#16279](babel/babel#16279) Fix decorator this memoization ([@JLHwung](https://github.com/JLHwung)) - [#16266](babel/babel#16266) Preserve `static` on decorated private `accessor` ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - [#16258](babel/babel#16258) fix: handle decorated async private method and generator ([@JLHwung](https://github.com/JLHwung)) - `babel-helper-create-class-features-plugin`, `babel-plugin-proposal-decorators`, `babel-plugin-transform-async-generator-functions`, `babel-plugin-transform-private-methods`, `babel-plugin-transform-private-property-in-object`, `babel-plugin-transform-typescript`, `babel-preset-env` - [#16275](babel/babel#16275) Fix class private properties when `privateFieldsAsProperties` ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-helpers` - [#16268](babel/babel#16268) Do not consider `arguments` in a helper as a global reference ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-helpers`, `babel-plugin-proposal-decorators` - [#16270](babel/babel#16270) Handle symbol key class elements decoration ([@JLHwung](https://github.com/JLHwung)) - [#16265](babel/babel#16265) Do not define `access.get` for public setter decorators ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) ##### 💅 Polish - `babel-core`, `babel-helper-create-class-features-plugin`, `babel-preset-env` - [#12428](babel/babel#12428) Suggest using `BABEL_SHOW_CONFIG_FOR` for config problems ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) ##### 🏠 Internal - `babel-helper-transform-fixture-test-runner` - [#16278](babel/babel#16278) Continue writing `output.js` when `exec.js` throws ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) ##### 🔬 Output optimization - `babel-helper-create-class-features-plugin`, `babel-plugin-proposal-decorators` - [#16306](babel/babel#16306) Avoid intermediate functions for private accessors with decs ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-helper-create-class-features-plugin`, `babel-helpers`, `babel-plugin-proposal-decorators`, `babel-plugin-proposal-pipeline-operator`, `babel-plugin-transform-class-properties` - [#16294](babel/babel#16294) More aggressively inline decorators in the static block ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-helper-create-class-features-plugin`, `babel-helpers`, `babel-plugin-transform-private-methods` - [#16283](babel/babel#16283) Do not use `classPrivateMethodGet` ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-helper-create-class-features-plugin`, `babel-helpers`, `babel-plugin-proposal-decorators` - [#16287](babel/babel#16287) Reduce decorator static property size ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) - `babel-helper-create-class-features-plugin`, `babel-plugin-proposal-decorators`, `babel-plugin-transform-class-properties` - [#16280](babel/babel#16280) Reduce element decorator temp variables ([@JLHwung](https://github.com/JLHwung)) - `babel-helper-create-class-features-plugin`, `babel-helper-fixtures`, `babel-helpers`, `babel-plugin-bugfix-v8-spread-parameters-in-optional-chaining`, `babel-plugin-proposal-decorators`, `babel-plugin-proposal-destructuring-private`, `babel-plugin-proposal-optional-chaining-assign`, `babel-plugin-transform-class-properties`, `babel-plugin-transform-class-static-block`, `babel-plugin-transform-private-methods`, `babel-plugin-transform-private-property-in-object`, `babel-preset-env`, `babel-runtime-corejs2`, `babel-runtime-corejs3`, `babel-runtime` - [#16261](babel/babel#16261) Do not use descriptors for private class elements ([@nicolo-ribaudo](https://github.com/nicolo-ribaudo)) - `babel-helpers`, `babel-plugin-proposal-decorators` - [#16263](babel/babel#16263) Reduce helper size for decorator 2023-11 ([@liuxingbaoyu](https://github.com/liuxingbaoyu)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.vylpes.xyz/RabbitLabs/random-bunny/pulls/156 Co-authored-by: Renovate Bot <renovate@vylpes.com> Co-committed-by: Renovate Bot <renovate@vylpes.com>

fix arguments

ec9fad6

liuxingbaoyu changed the title ~~Fix the support of arguments in private get/set method~~ Fix the support of arguments in private get/set method Feb 27, 2024

nicolo-ribaudo reviewed Feb 27, 2024

View reviewed changes

Update packages/babel-plugin-transform-private-methods/test/fixtures/…

0167694

…accessors/arguments/exec.js Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

review

0584b20

liuxingbaoyu force-pushed the improve-this-size branch from baecd7a to 0584b20 Compare February 27, 2024 15:02

liuxingbaoyu added PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Private Methods labels Feb 27, 2024

nicolo-ribaudo approved these changes Feb 27, 2024

View reviewed changes

fix types

0918a87

nicolo-ribaudo added this to the v7.24.0 milestone Feb 27, 2024

JLHwung approved these changes Feb 27, 2024

View reviewed changes

nicolo-ribaudo merged commit 9905eb2 into babel:feat-7.24.0/decorators Feb 27, 2024

This was referenced May 18, 2024

[Snyk] Upgrade: , tiff-es/fewpjs-getter-and-setter-methods-dc-web-091619#153

Open

[Snyk] Upgrade: , tiff-es/fewpjs-document-onload-dc-web-091619#151

Open

mdfkbtc mentioned this pull request May 18, 2024

[Snyk] Upgrade @babel/preset-env from 7.5.0 to 7.24.4 mdfkbtc/veles-mobile-wallet-mdfkbtc#1687

Open

tiff-es mentioned this pull request May 18, 2024

[Snyk] Upgrade: , tiff-es/fewpjs-adding-behavior-with-methods-dc-web-091619#155

Open

nejidevelops mentioned this pull request May 18, 2024

[Snyk] Upgrade: , nejidevelops/phase-0-intro-to-js-2-looping-code-along#9

Open

AnushaSalian mentioned this pull request May 19, 2024

[Snyk] Upgrade: , virtual-labs/ph3-lab-mgmt#433

Open

bee22193 mentioned this pull request May 20, 2024

[Snyk] Upgrade: , bee22193/mnmlurl#1171

Open

anandgupta193 mentioned this pull request May 20, 2024

[Snyk] Upgrade: , anandgupta193/sortNsuffle-react#1047

Open

bee22193 mentioned this pull request May 20, 2024

[Snyk] Upgrade: , bee22193/mnmlurl#1172

Open

This was referenced May 20, 2024

[Snyk] Upgrade: , nejidevelops/phase-0-intro-to-js-2-objects-lab#10

Open

[Snyk] Upgrade: , nejidevelops/phase-0-intro-to-js-2-objects-lab#11

Open

This was referenced May 27, 2024

[Snyk] Upgrade: , nejidevelops/phase-1-destructuring-assignment#18

Open

[Snyk] Upgrade: , nejidevelops/phase-0-intro-to-js-2-objects-lab#18

Open

This was referenced May 27, 2024

[Snyk] Upgrade: , tiff-es/js-looping-and-iteration-looping-code-along-dc-web-091619#158

Open

[Snyk] Upgrade: , tiff-es/js-data-structures-objects-lab-dc-web-091619#149

Open

This was referenced May 28, 2024

[Snyk] Upgrade: , , richyhoopd/Video-App#1133

Open

[Snyk] Upgrade: , , richyhoopd/RichyFlix#853

Open

tiff-es mentioned this pull request May 28, 2024

[Snyk] Upgrade: , tiff-es/fewpjs-document-onload-dc-web-091619#156

Open

tiff-es mentioned this pull request May 28, 2024

[Snyk] Upgrade: , tiff-es/js-looping-and-iteration-looping-code-along-dc-web-091619#159

Open

bee22193 mentioned this pull request May 28, 2024

[Snyk] Upgrade: , bee22193/mnmlurl#1180

Open

nejidevelops mentioned this pull request May 28, 2024

[Snyk] Upgrade: , nejidevelops/phase-0-intro-to-js-2-objects-lab#19

Open

AnushaSalian mentioned this pull request May 28, 2024

[Snyk] Upgrade: , virtual-labs/ph3-lab-mgmt#444

Open

YoYBaBy mentioned this pull request May 28, 2024

[Snyk] Upgrade: , , , YoYBaBy/docs#812

Open

venkatarao-palaparthi mentioned this pull request May 28, 2024

[Snyk] Upgrade: , , , , , , , , venkatarao-palaparthi/docs#428

Open

richyhoopd mentioned this pull request May 29, 2024

[Snyk] Upgrade: , , richyhoopd/Video-App#1134

Open

github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 29, 2024

github-actions bot locked as resolved and limited conversation to collaborators May 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix the support of `arguments` in private `get/set` method#16307

Fix the support of `arguments` in private `get/set` method#16307
nicolo-ribaudo merged 4 commits intobabel:feat-7.24.0/decoratorsfrom
liuxingbaoyu:improve-this-size

liuxingbaoyu commented Feb 27, 2024

Uh oh!

babel-bot commented Feb 27, 2024 •

edited

Loading

Uh oh!

nicolo-ribaudo left a comment

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

nicolo-ribaudo Feb 27, 2024

Uh oh!

liuxingbaoyu commented Feb 27, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

liuxingbaoyu commented Feb 27, 2024

Uh oh!

babel-bot commented Feb 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolo-ribaudo left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

nicolo-ribaudo Feb 27, 2024

Choose a reason for hiding this comment

Uh oh!

liuxingbaoyu commented Feb 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

babel-bot commented Feb 27, 2024 •

edited

Loading

liuxingbaoyu commented Feb 27, 2024 •

edited

Loading