[ts] Fix compiling extended exported nested namespace#15798
Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom Jul 20, 2023
Merged
[ts] Fix compiling extended exported nested namespace#15798nicolo-ribaudo merged 1 commit intobabel:mainfrom
nicolo-ribaudo merged 1 commit intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54902/ |
JLHwung
approved these changes
Jul 19, 2023
Contributor
JLHwung
left a comment
There was a problem hiding this comment.
PR idea: we can make a custom ESLint rule to forbid the pattern path.parentPath.replace*.
liuxingbaoyu
approved these changes
Jul 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
path.parentPath.replaceWithalways causes bugs, because the traversal continues in a detached tree.