rescan gt token at the end of type args parsing#15631
Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom May 17, 2023
Merged
rescan gt token at the end of type args parsing#15631nicolo-ribaudo merged 1 commit intobabel:mainfrom
nicolo-ribaudo merged 1 commit intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54420/ |
existentialism
approved these changes
May 16, 2023
liuxingbaoyu
approved these changes
May 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an edge case where
>=is incorrectly parsed as>and=at the boundary between type arguments and non-type js expressions. The token>is parsed in previousnode.paramswheninTypeistrue. Here we should reset the tokenizer and rescan the token.