fix: enable transform-block-scoping with generators feature (#12806)#15606
Merged
nicolo-ribaudo merged 3 commits intobabel:mainfrom May 8, 2023
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54379/ |
Contributor
Author
|
I am not sure why the tests wouldn't pass. It's like it's ignoring the new compat-data. 🤷 |
Contributor
|
Can you also update |
0b87763 to
e0f7f69
Compare
Contributor
Author
|
Updated. It passes all tests locally with |
Member
|
I updated the Babel 8 tests, hopefully CI will be green now :) |
JLHwung
approved these changes
May 8, 2023
nicolo-ribaudo
approved these changes
May 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
generatorstotransform-block-scopingfeatures:babel/packages/babel-compat-data/scripts/data/plugin-features.js
Lines 104 to 106 in 2942629
as asked by @nicolo-ribaudo in #12806, and adds a regression test for Chrome 49 preset.