Skip to content

fix: formidable dependency vulnerable to arbitrary#7533

Merged
jasonsaayman merged 5 commits intov1.xfrom
fix/6366-formidable-dependency-vulnerable-to-arbitrary
Mar 19, 2026
Merged

fix: formidable dependency vulnerable to arbitrary#7533
jasonsaayman merged 5 commits intov1.xfrom
fix/6366-formidable-dependency-vulnerable-to-arbitrary

Conversation

@jasonsaayman
Copy link
Copy Markdown
Member

@jasonsaayman jasonsaayman commented Mar 19, 2026

Closes #6366


Summary by cubic

Updates formidable to v3 to address the reported vulnerability (Linear 6366). Updates the test server and assertions to the new API (arrays for fields/files).

Description

  • Summary of changes

    • Bumped formidable from ^2.1.5 to ^3.2.4 (lockfile to 3.5.4).
    • Switched to the IncomingForm named export in the test server and tests.
    • Updated multipart assertions to expect array shapes for fields and files.
  • Reasoning

    • Fixes the security vulnerability tracked in Linear 6366.
    • Aligns test code with formidable@3 API changes.
  • Additional context

    • formidable is a dev-only dependency used in tests/local servers.
    • No changes expected for consumers.

Docs

  • No user-facing API changes.
  • Contributor note: multipart parse results now return arrays per key (e.g., fields.foo => ['bar'], files.file1[0]).

Testing

  • Modified tests in tests/setup/server.js and tests/unit/adapters/http.test.js to use IncomingForm and array-shaped results.
  • No new tests added; updates bring existing tests in line with formidable@3 behavior.

Written for commit c4fe4d1. Summary will update on new commits.

@jasonsaayman jasonsaayman self-assigned this Mar 19, 2026
@jasonsaayman jasonsaayman added priority::high A high priority issue commit::fix The PR is related to a bugfix labels Mar 19, 2026
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@jasonsaayman jasonsaayman merged commit 4d8931c into v1.x Mar 19, 2026
24 of 25 checks passed
@jasonsaayman jasonsaayman deleted the fix/6366-formidable-dependency-vulnerable-to-arbitrary branch March 19, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit::fix The PR is related to a bugfix priority::high A high priority issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Formidable arbitrary file upload vulnerability

1 participant