Merged
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="tests/module/cjs/package.json">
<violation number="1" location="tests/module/cjs/package.json:16">
P1: This downgrades the CJS module test package to TypeScript 4.9, so those tests will no longer exercise the TS 5.9 behavior the rest of the repo was upgraded to.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="tests/module/esm/package.json">
<violation number="1" location="tests/module/esm/package.json:14">
P2: Keep this fixture on an exact `@types/node` version. The caret range makes the ESM test matrix non-deterministic again and contradicts the stated goal of locking fixture deps to the target runtime.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Upgrade to
typescript@^5.9.3across the repo and fixtures, update generated helpers, and clean up lockfiles. Keep the CJS fixture on TS 4.9 for Node 12.Description
Summary of changes
typescriptto^5.9.3in root and fixtures (test/module/ts*,test/module/typings/*,tests/module/esm).tests/module/cjsontypescript@4.9.5with@types/node@12.20.55.test/module/ts/index.jsto TS 5’s__importStarhelper.>=14.17for TS 5.@types/node; keep^20.0.0.Reasoning
Additional context
Docs
5.9.>=14.17for tasks using TS 5; the CJS fixture intentionally stays on TS 4.9 with Node 12 types.Testing
>=14.17for TS 5 tasks and a Node 12 job for the CJS fixture.Written for commit 1741de3. Summary will update on new commits.