revert: transformrequest typing 10745#10810
Merged
jasonsaayman merged 2 commits intov1.xfrom Apr 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Reverts the recent
transformRequest/transformResponsetyping change and restores the v1.x non-generic transformer types inaxios. Also removes related typing tests and simplifies test fixtures.Description
A clear and concise description of the PR.
Use this section for review hints, explanations or discussion points.
AxiosRequestTransformer<D>andAxiosResponseTransformer<T>to non-generic interfaces usingany.AxiosRequestConfig<D>.transformRequestto accept non-generic transformers.repoRootsymlink and parameter.Docs
Please update
/docs/to remove mentions/examples of generic transformer types and reflect the non-generictransformRequest/transformResponsesignatures.Testing
createTempFixturesignature (norepoRoot).Semantic version impact
Patch: reverts typings to the established v1.x surface without runtime changes.
Written for commit 2de9cc7. Summary will update on new commits. Review in cubic