Skip to content

revert: transformrequest typing 10745#10810

Merged
jasonsaayman merged 2 commits intov1.xfrom
revert/transformrequest-typing-10745
Apr 27, 2026
Merged

revert: transformrequest typing 10745#10810
jasonsaayman merged 2 commits intov1.xfrom
revert/transformrequest-typing-10745

Conversation

@jasonsaayman
Copy link
Copy Markdown
Member

@jasonsaayman jasonsaayman commented Apr 27, 2026

Summary by cubic

Reverts the recent transformRequest/transformResponse typing change and restores the v1.x non-generic transformer types in axios. Also removes related typing tests and simplifies test fixtures.

Description

A clear and concise description of the PR.

Use this section for review hints, explanations or discussion points.

  • Summary of changes
    • Revert AxiosRequestTransformer<D> and AxiosResponseTransformer<T> to non-generic interfaces using any.
    • Revert AxiosRequestConfig<D>.transformRequest to accept non-generic transformers.
    • Remove transformer typing tests and adjust existing TS module tests.
    • Simplify fixture helpers by removing the repoRoot symlink and parameter.
  • Reasoning
    • Restore v1.x compatibility and avoid downstream TypeScript friction introduced by the generic transformer types.
  • Additional context
    • No runtime behavior changes. Types are returned to their pre-change shape.

Docs

Please update /docs/ to remove mentions/examples of generic transformer types and reflect the non-generic transformRequest/transformResponse signatures.

Testing

  • Removed: generic transformer typing tests in both CJS and ESM suites.
  • Updated: module typing tests and fixture helper calls to the new createTempFixture signature (no repoRoot).
  • No new tests added. Existing module compile/type-check tests continue to validate typings.

Semantic version impact

Patch: reverts typings to the established v1.x surface without runtime changes.

Written for commit 2de9cc7. Summary will update on new commits. Review in cubic

@jasonsaayman jasonsaayman merged commit d9b941c into v1.x Apr 27, 2026
31 of 32 checks passed
@jasonsaayman jasonsaayman deleted the revert/transformrequest-typing-10745 branch April 27, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant