fix: close redirect listiner chanin correctly to no longer stack#10800
Merged
jasonsaayman merged 2 commits intov1.xfrom Apr 24, 2026
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Confidence score: 3/5
- There is a medium-severity, high-confidence cleanup bug in
lib/adapters/http.js: on close, only the final redirect socket is disassociated, leaving stalekAxiosCurrentReqreferences on earlier redirect-hop sockets. - This creates a concrete regression risk around connection/socket lifecycle handling during redirects, so the change carries some user-impacting risk until cleanup is applied consistently across hops.
- Pay close attention to
lib/adapters/http.js- ensure socket disassociation runs for every redirect hop, not just the last request socket.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="lib/adapters/http.js">
<violation number="1" location="lib/adapters/http.js:986">
P2: Only the last redirect socket is disassociated on close, leaving stale `kAxiosCurrentReq` on earlier hop sockets.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Member
Author
|
@cubic-dev-ai please review again |
Contributor
@jasonsaayman I have started the AI code review. It will take a few minutes to complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixes listener stacking in the Node HTTP adapter by cleaning up all redirect-bound sockets with a single close listener. A single request can now follow many redirects without MaxListenersExceededWarning or stale keep‑alive socket refs.
Description
RedirectableRequestin aSetand clearkAxiosCurrentReqfor all onreq.once('close', ...).follow-redirectsre-emitssocketfor each hop.kAxiosCurrentReqon earlier-hop sockets returned to the keep‑alive pool.axios’s Node HTTP adapter.Docs
/docs/under redirects/HTTP adapter that long redirect chains no longer stack listeners or leak socket refs; highmaxRedirectsvalues are safe.Testing
MaxListenersExceededWarningwhen following 11+ redirects.Semantic version impact
Written for commit fbf7ec7. Summary will update on new commits.