fix: short-circuits on any truthy non-boolean in withXSRFToken#10762
Merged
jasonsaayman merged 2 commits intov1.xfrom Apr 19, 2026
Merged
Conversation
…via-prototype-pollution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixes XSRF token leakage by requiring
withXSRFToken === truefor cross-origin requests; otherwise the token only sends for same-origin. Adds browser tests to block truthy non-boolean values and prototype pollution (AXI-205).Description
lib/helpers/resolveConfig.js, compute a strictshouldSendXSRFboolean.withXSRFToken === true, or whenwithXSRFTokenis null/undefined and the URL is same-origin.Object.prototypepollution (GHSA-xx6v-rp6x-q39c).v1.x(no functional changes).Docs
Please update
/docs/to clarifywithXSRFToken:trueforces sending the token cross-origin.Testing
tests/browser/xsrf.browser.test.jsto:Object.prototype.withXSRFToken === truecross-origin and default same-origin.Semantic version impact
Patch: security bug fix with no API changes.
Written for commit bf3a288. Summary will update on new commits.