fix: prevent authentication bypass via prototype pollution#10761
Merged
jasonsaayman merged 2 commits intov1.xfrom Apr 19, 2026
Merged
Conversation
…ype-pollution-gadget
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Prevents authentication bypass via prototype pollution by replacing
inchecks inmergeConfigwithutils.hasOwnProp, sovalidateStatuscannot be inherited fromObject.prototype. Adds targeted tests to ensure 4xx/5xx responses are still rejected under pollutedObject.prototype.validateStatus(AXI-207, GHSA-w9j2-pvgh-6h63).Description
inforutils.hasOwnPropinmergeConfigdirect key merging; added focused tests forvalidateStatusinheritance and behavior.intraverses the prototype chain, letting a pollutedvalidateStatusoverride config and accept all responses.Docs
/docs/to statemergeConfigonly merges own properties and note protection against prototype pollution (e.g.,validateStatuscannot be inherited).Testing
tests/unit/prototypePollution.test.js:validateStatuscomes from defaults whenObject.prototype.validateStatusis set.Object.prototype.validateStatusis polluted.Object.prototype.validateStatusto avoid cross-test leakage.Semantic version impact
Written for commit 2f1f96a. Summary will update on new commits.