Skip to content

chore: added additional testing for prototype pollution#10760

Merged
jasonsaayman merged 1 commit intov1.xfrom
fix/axi-210-invisible-json-response-tampering-via-prototype-pollution
Apr 19, 2026
Merged

chore: added additional testing for prototype pollution#10760
jasonsaayman merged 1 commit intov1.xfrom
fix/axi-210-invisible-json-response-tampering-via-prototype-pollution

Conversation

@jasonsaayman
Copy link
Copy Markdown
Member

@jasonsaayman jasonsaayman commented Apr 19, 2026

Summary by cubic

Adds an end-to-end test to ensure a prototype-polluted Object.prototype.parseReviver cannot tamper with JSON responses in axios.get. Strengthens coverage for AXI-210 (invisible JSON response tampering via prototype pollution).

Description

  • Adds an E2E test in tests/unit/prototypePollution.test.js that:
    • Pollutes Object.prototype.parseReviver
    • Serves a JSON payload over a local HTTP server
    • Asserts the reviver is never called, the response equals the original payload, and no keys are exfiltrated
  • Validates the fix path for GHSA-3w6x-2g7m-8v23 through the full axios.get pipeline

Docs

  • Suggest adding a short security note in /docs/ (e.g., security.md) describing that response parsing is hardened against prototype-polluted revivers, referencing AXI-210 and GHSA-3w6x-2g7m-8v23

Testing

  • Added: one E2E unit test under tests/unit/prototypePollution.test.js
  • No other tests changed

Semantic version impact

  • None (tests-only change; no API or behavior changes)

Written for commit 3a57ac0. Summary will update on new commits.

@jasonsaayman jasonsaayman self-assigned this Apr 19, 2026
@jasonsaayman jasonsaayman added priority::medium A medium priority commit::fix The PR is related to a bugfix type::security The PR is a secuirty related changed normally from a CVE labels Apr 19, 2026
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@jasonsaayman jasonsaayman changed the title chore: added additional testing for this issue chore: added additional testing for prototype pollution Apr 19, 2026
@jasonsaayman jasonsaayman merged commit f0b9867 into v1.x Apr 19, 2026
25 checks passed
@jasonsaayman jasonsaayman deleted the fix/axi-210-invisible-json-response-tampering-via-prototype-pollution branch April 19, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit::fix The PR is related to a bugfix priority::medium A medium priority type::security The PR is a secuirty related changed normally from a CVE

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant