fix: strip crlf correctly from multipart headers#10758
Merged
jasonsaayman merged 2 commits intov1.xfrom Apr 19, 2026
Merged
Conversation
…data-body-via-unsanitized
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Sanitizes multipart headers by stripping CR and LF from
Blob.typeto prevent header injection informDataToStream. Adds tests to confirm no injection, correct defaults, and stable Content-Length.Description
Content-Typederived fromBlob.type.application/octet-streamwhen missing.Content-Dispositionare percent-encoded and safe.v1.x; no functional changes.Docs
/docs/forformDataToStreamstating:Blob.typeis sanitized to remove CR/LF.Content-Dispositionare percent-encoded.Testing
Blob.type(incl. bare CR or LF).Content-Typevalues.application/octet-stream.Content-Disposition.Content-Lengthaccounting.Semantic version impact
Patch release: security bug fix with no API changes.
Written for commit 59f848c. Summary will update on new commits.