test: expand shouldBypassProxy coverage for wildcard, IPv6, and edge cases#10723
Merged
jasonsaayman merged 2 commits intov1.xfrom Apr 15, 2026
Merged
Conversation
Copilot
AI
changed the title
[WIP] Add comprehensive test coverage for shouldBypassProxy function
test: expand shouldBypassProxy coverage for wildcard, IPv6, and edge cases
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shouldBypassProxytest coverage was missing several high-signalno_proxyscenarios (wildcard, bracketed IPv6 with ports, and malformed/empty inputs). This PR adds focused unit tests to cover those paths and lock expected behavior.Coverage additions in
tests/unit/helpers/shouldBypassProxy.test.jsno_proxy='*'case to verify global bypass behavior across hostname types.[::1]:8080) and non-matching port case.no_proxybehavior to ensure bypass is not triggered.falsereturn.Wildcard and port-specific matching scenarios
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
no-such-domain-987654.com/opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node --experimental-import-meta-resolve --require /home/REDACTED/work/axios/axios/node_modules/vitest/suppress-warnings.cjs --conditions node --conditions development /home/REDACTED/work/axios/axios/node_modules/vitest/dist/workers/forks.js(dns block)notexistsurl.in.nowhere/opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node --experimental-import-meta-resolve --require /home/REDACTED/work/axios/axios/node_modules/vitest/suppress-warnings.cjs --conditions node --conditions development /home/REDACTED/work/axios/axios/node_modules/vitest/dist/workers/forks.js(dns block)postman-echo.com/opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node --experimental-import-meta-resolve --require /home/REDACTED/work/axios/axios/node_modules/vitest/suppress-warnings.cjs --conditions node --conditions development /home/REDACTED/work/axios/axios/node_modules/vitest/dist/workers/forks.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt