feat: added initial ai based translations#10705
Merged
jasonsaayman merged 2 commits intov1.xfrom Apr 14, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
5 issues found across 103 files
Confidence score: 4/5
- This PR is likely safe to merge, with risk concentrated in documentation examples rather than core runtime code, so impact is mostly on copied usage patterns.
- Most severe issue: the retry docs in
docs/es/pages/advanced/retry.mdanddocs/zh/pages/advanced/retry.mdassumeRetry-Afteris numeric seconds; missing HTTP-date/invalid-value handling can lead users to retry too early. - There are also concrete snippet correctness problems (
fsnot imported indocs/es/pages/advanced/multipart-form-data-format.md, repeatedconst instanceindocs/zh/pages/advanced/adapters.md, and abort-delay mismatch indocs/es/pages/advanced/retry.md) that can cause copy-paste errors. - Pay close attention to
docs/es/pages/advanced/retry.md,docs/zh/pages/advanced/retry.md,docs/es/pages/advanced/multipart-form-data-format.md, anddocs/zh/pages/advanced/adapters.md- fix retry semantics and invalid JS examples before publishing.
Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed. cubic prioritises the most important files to review.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/es/pages/advanced/multipart-form-data-format.md">
<violation number="1" location="docs/es/pages/advanced/multipart-form-data-format.md:15">
P2: The Node.js example uses `fs.createReadStream` but never imports `fs`, so this snippet will throw a ReferenceError when copied.</violation>
</file>
<file name="docs/es/pages/advanced/retry.md">
<violation number="1" location="docs/es/pages/advanced/retry.md:91">
P1: Handle `Retry-After` HTTP-date values (and invalid values) instead of assuming it is always numeric seconds.</violation>
<violation number="2" location="docs/es/pages/advanced/retry.md:128">
P2: The comment claims abort cancels pending retry delays, but the shown retry-delay code does not connect delay timers to the abort signal.</violation>
</file>
<file name="docs/zh/pages/advanced/retry.md">
<violation number="1" location="docs/zh/pages/advanced/retry.md:92">
P2: The `Retry-After` handling only supports numeric seconds; HTTP-date values will not be honored and can cause immediate retries.</violation>
</file>
<file name="docs/zh/pages/advanced/adapters.md">
<violation number="1" location="docs/zh/pages/advanced/adapters.md:16">
P2: This code sample redeclares `const instance` multiple times in the same scope, which makes the snippet invalid JavaScript.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds Spanish, French, and Chinese docs and enables
vitepresslocale routing with per-language nav/sidebars. Users can browse/es,/fr, and/zhwith localized home, Getting Started, Advanced, and Misc content (fallbacks to English where missing).Description
Summary of changes
vitepresslocales with language-specific nav/sidebars indocs/.vitepress/config.mts.es,fr,zhincluding new Advanced topics (Headers, Fetch adapter, HTTP/2, Rate limiting, Progress, Retry)./); localized routes under/es,/fr,/zh.Reasoning
axiosdocs accessible to more readers and align with updates merged fromv1.x.Additional context
Testing
npx vitepress dev docs) and visit/,/es/,/fr/,/zh/.npx vitepress build docs) to ensure no errors.Written for commit d627bd8. Summary will update on new commits.