fix: update the implementation to rather parse out the values than throw#10687
Merged
jasonsaayman merged 3 commits intov1.xfrom Apr 11, 2026
Merged
fix: update the implementation to rather parse out the values than throw#10687jasonsaayman merged 3 commits intov1.xfrom
jasonsaayman merged 3 commits intov1.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Sanitizes request header values by stripping invalid bytes and trimming tabs/spaces instead of throwing, preventing header injection across browser and Node. Also hardens proxy bypass by treating
localhost,127.0.0.1, and::1as equivalent loopbacks inNO_PROXYmatching.Description
AxiosHeaders; remove disallowed bytes, trim SP/HTAB, handle strings and arrays; no throws.shouldBypassProxy: treatlocalhost,127.0.0.1, and::1as equivalent loopbacks inNO_PROXYmatching.Testing
'\tok\r\nInjected: yes 'becomes'okInjected: yes'; noInjectedheader.fetchandhttpadapters: echo servers confirm same sanitized value and no extra headers.AxiosHeadersandshouldBypassProxytests updated: expect sanitized string/array values; verify loopback equivalence acrosslocalhost/127.0.0.1/::1.Written for commit 98799bf. Summary will update on new commits.