feat: add checks to support deno and bun#10652
Merged
jasonsaayman merged 14 commits intov1.xfrom Apr 5, 2026
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
There was a problem hiding this comment.
2 issues found across 23 files
Confidence score: 2/5
- High-confidence workflow path regressions in
.github/workflows/release-branch.ymland.github/workflows/run-ci.ymlcopy artifacts intodist/dist, which makes../../../dist/esm/axios.jsunavailable during Deno imports. - This creates a concrete CI/regression risk (severity 8/10 in both findings): validation and release-related jobs are likely to fail until the dist copy/extraction paths are corrected.
- Pay close attention to
.github/workflows/release-branch.yml,.github/workflows/run-ci.yml- both workflows appear to nestdistincorrectly, breaking expected Deno import resolution.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/release-branch.yml">
<violation number="1" location=".github/workflows/release-branch.yml:235">
P1: The Deno artifact copy command nests `dist` (`dist/dist/...`), so the test import path `../../../dist/esm/axios.js` will not exist.</violation>
</file>
<file name=".github/workflows/run-ci.yml">
<violation number="1" location=".github/workflows/run-ci.yml:229">
P1: The dist extraction step copies into `dist/dist` instead of `dist`, so Deno imports from `../../../dist/esm/axios.js` won’t resolve correctly.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/run-ci.yml">
<violation number="1" location=".github/workflows/run-ci.yml:230">
P2: The workflow calls `deno task ... install`, but `tests/smoke/deno/deno.json` has no `install` task. This will fail the Deno CI job.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Add CI smoke tests for
bunanddenoto verifyaxiosworks in both runtimes and block release bumps if they fail. Includes new smoke suites and scripts; no API changes.New Features
bun-smoke-testsanddeno-smoke-teststo.github/workflows/run-ci.ymlandrelease-branch.yml; the release bump job now depends on them.bun: installs the packed tarball viabun add file:.../axios.tgzand runsbun test.deno: extractsdistfrom the tarball, runsdeno install, thendeno task test.tests/smoke/bunandtests/smoke/deno; addedtest:smoke:bunandtest:smoke:denoscripts; updated.gitignore.Testing
bunsmoke coverage:fetchandhttpadapters, headers, nativeFormDataandform-data, interceptors, progress, timeout, cancellation, imports, default adapter.denosmoke coverage:fetchadapter, headers (defaults/custom), cancellation, errors (404/500), methods, JSON body, imports viadeno.json.npm run test:smoke:bunandnpm run test:smoke:deno.Written for commit 43c1e32. Summary will update on new commits.