Skip to content

fix(ci): narrow workflow permissions to least privilege#10637

Merged
jasonsaayman merged 3 commits intoaxios:v1.xfrom
shaanmajid:fix-excessive-permissions
Apr 3, 2026
Merged

fix(ci): narrow workflow permissions to least privilege#10637
jasonsaayman merged 3 commits intoaxios:v1.xfrom
shaanmajid:fix-excessive-permissions

Conversation

@shaanmajid
Copy link
Copy Markdown
Contributor

@shaanmajid shaanmajid commented Apr 2, 2026

Summary

Fixes the excessive-permissions findings flagged by zizmor (#10618) and removes the .github/zizmor.yml suppression that was deferring this work.

release-branch.yml: moves contents: write and pull-requests: write from workflow-level down to the bump-version-and-create-pr job, which is the only job that creates commits and opens a PR. The test and smoke test jobs now inherit only contents: read.

run-ci.yml: removes security-events: write from workflow-level. dependency-review-action only requires contents: read.


Summary by cubic

Narrowed GitHub Actions permissions to least privilege to resolve zizmor excessive-permissions findings and remove the suppression. CI behavior stays the same; only the bump job has write access.

  • Description

    • release-branch.yml: default contents: read; grant contents: write and pull-requests: write only to bump-version-and-create-pr. Other jobs inherit read-only.
    • run-ci.yml: removed security-events: write; dependency-review-action runs with contents: read.
    • Removed .github/zizmor.yml suppression for excessive-permissions.
  • Testing

    • No code tests changed; workflows validated via CI runs.
    • Verified bump job can push commits and open a PR; dependency review still runs.

Written for commit 0bd3a67. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@shaanmajid
Copy link
Copy Markdown
Contributor Author

CI failure looks to be just a flaky test but can't rerun to verify.

Copy link
Copy Markdown
Member

@jasonsaayman jasonsaayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for all the help 🔥

@jasonsaayman jasonsaayman merged commit 3ca1306 into axios:v1.x Apr 3, 2026
20 checks passed
@jasonsaayman jasonsaayman added priority::high A high priority issue commit::ci The PR is related to CI type::security The PR is a secuirty related changed normally from a CVE labels Apr 3, 2026
@shaanmajid shaanmajid deleted the fix-excessive-permissions branch April 3, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit::ci The PR is related to CI priority::high A high priority issue type::security The PR is a secuirty related changed normally from a CVE

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants