fix: updated release flow to match the current flows#10562
Merged
jasonsaayman merged 2 commits intov1.xfrom Mar 25, 2026
Merged
fix: updated release flow to match the current flows#10562jasonsaayman merged 2 commits intov1.xfrom
jasonsaayman merged 2 commits intov1.xfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Confidence score: 4/5
- This PR looks safe to merge overall, with one moderate workflow configuration risk rather than an application/runtime regression.
- In
.github/workflows/release-branch.yml,actions/dependency-review-actionis used underworkflow_dispatchwithoutbase-ref/head-ref; on non-PR events this can cause the dependency review step to run with incomplete context or fail to compare changes as intended. - Given the issue is medium severity (5/10) with reasonably strong confidence (7/10) and scoped to CI behavior, the merge risk appears limited but worth addressing soon.
- Pay close attention to
.github/workflows/release-branch.yml- dependency-review inputs for manual dispatch are likely incomplete without explicit refs.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/release-branch.yml">
<violation number="1" location=".github/workflows/release-branch.yml:50">
P2: `actions/dependency-review-action` is being run in a `workflow_dispatch` workflow, but no `base-ref`/`head-ref` are provided. The action’s docs call out `base-ref`/`head-ref` as the mechanism for non-PR event types, so consider setting them here to ensure the dependency comparison is done against the intended refs.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Updates the release-branch workflow to build, upload, and test the packed npm tarball, aligning with the current publish flow. Adds CJS/ESM module tests across Node versions and removes the dependency review step.
Description
Summary of changes
npm packand uploadaxios-*.tgzasaxios-tarball(fail if missing).actions/checkout@v6,actions/setup-node@v6,actions/upload-artifact@v7,actions/download-artifact@v8.Reasoning
Additional context
axios(dist) toaxios-tarball(npm pack).npm install --no-save ../../../artifacts/axios-*.tgz.bump-version-and-create-pralso depend on the new module test jobs to fully gate releases?Testing
axiosfrom the packed tarball.Written for commit 183fedd. Summary will update on new commits.