Allow ArrayBuffer and related views as data#10
Merged
mzabriskie merged 1 commit intoaxios:masterfrom Sep 18, 2014
Merged
Conversation
In order to push binary data under the form of ArrayBuffer and its related views (Int8Array, ...) one needs not to stringify those. For the XHR adapter there is nothing to do as it natively supports ArrayBuffer in req.send(). Node's http adapter supports only string or Buffer thus a transformation to Buffer is required before setting content length header.
mzabriskie
added a commit
that referenced
this pull request
Sep 18, 2014
Allow ArrayBuffer and related views as data
Member
|
@mathbruyen thank you for the pull requests! |
Author
|
You're welcome, thanks for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to push binary data under the form of
ArrayBufferand its related views (Int8Array, ...) one needs not to stringify those.For the XHR adapter there is nothing to do as it natively supports
ArrayBufferview inreq.send().Node's http adapter supports only string or
Bufferthus a transformation toBufferis required before setting content length header.