Fix E3677 false positive when Code is a string (aws-cli pattern)#4399
Merged
kddejong merged 1 commit intoaws-cloudformation:mainfrom Mar 23, 2026
Merged
Fix E3677 false positive when Code is a string (aws-cli pattern)#4399kddejong merged 1 commit intoaws-cloudformation:mainfrom
kddejong merged 1 commit intoaws-cloudformation:mainfrom
Conversation
E3012 has an exception for TEMPLATED_PROPERTY_CFN_PATHS that allows Code to be a string for aws-cli deployment patterns. This exception leaked into CfnLintJsonSchema if/then evaluation, causing the ZipFile runtime check to incorrectly fire. Reset the type validator to base cfn_type in CfnLintJsonSchema to prevent E3012 exceptions from affecting schema-based rule evaluation. Fixes aws-cloudformation#4397
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4399 +/- ##
==========================================
- Coverage 93.54% 93.44% -0.10%
==========================================
Files 418 422 +4
Lines 14145 14318 +173
Branches 2817 2858 +41
==========================================
+ Hits 13232 13380 +148
- Misses 567 581 +14
- Partials 346 357 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E3012 has an exception for TEMPLATED_PROPERTY_CFN_PATHS that allows Code to be a string for aws-cli deployment patterns. This exception leaked into CfnLintJsonSchema if/then evaluation, causing the ZipFile runtime check to incorrectly fire.
Reset the type validator to base cfn_type in CfnLintJsonSchema to prevent E3012 exceptions from affecting schema-based rule evaluation.
Fixes #4397
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.