Add unknown validation state for intrinsic functions in composite validators#4384
Merged
kddejong merged 1 commit intoaws-cloudformation:mainfrom Mar 6, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4384 +/- ##
==========================================
+ Coverage 93.54% 93.55% +0.01%
==========================================
Files 418 422 +4
Lines 14145 14280 +135
Branches 2817 2843 +26
==========================================
+ Hits 13232 13360 +128
- Misses 567 569 +2
- Partials 346 351 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…idators - Add unknown field to ValidationError and unresolvable_function_mode to Context - Update composite validators (if, oneOf, anyOf, allOf, not, contains) to propagate unknown errors when functions cannot be resolved - Add default function validators in _keywords_cfn.py that return unknown in unresolvable mode, overridden by full function rules at runtime - Filter unknown errors in Base.py and CfnLintJsonSchema - Return unknown from BaseFn.validate() in unresolvable mode - Fix oneOf to collect valid schemas in single pass - Add unit tests for unknown handling in all composite validators
b47ac48 to
3bbf41e
Compare
chrisqm-dev
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ValidationErrorandunresolvable_function_modeto Contextif,oneOf,anyOf,allOf,not,contains) to propagate unknown errors when functions cannot be resolved_keywords_cfn.pythat return unknown in unresolvable mode, overridden by full function rules at runtimeBase.pyandCfnLintJsonSchemaBaseFn.validate()in unresolvable modeoneOfto collect valid schemas in single passIssue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.