only add interceptor middlewares if configured #616
Merged
+66
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
relates aws/aws-sdk-go-v2#3197 |
Madrigal
approved these changes
Nov 11, 2025
| len(opts.Interceptors.BeforeSerialization) == 0 && len(opts.Interceptors.AfterSerialization) == 0 && | ||
| len(opts.Interceptors.BeforeRetryLoop) == 0 && | ||
| len(opts.Interceptors.BeforeAttempt) == 0 && | ||
| len(opts.Interceptors.BeforeSigning) == 0 && len(opts.Interceptors.AfterSigning) == 0 && |
Contributor
There was a problem hiding this comment.
very small nit on ordering, but this seems like it should go after all the BeforeX, or we could put them in the order they are added below on errors.Join
| return stack.Deserialize.Insert(&smithyhttp.InterceptAfterDeserialization{ | ||
| Interceptors: opts.Interceptors.AfterDeserialization, | ||
| }, "OperationDeserializer", middleware.Before) | ||
| return errors.Join( |
Contributor
There was a problem hiding this comment.
praise: This is probably even better since you can see all the errors related to adding interceptors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see comment in the source
this drops another 25M allocations when interceptors aren't in use (which will be mostly everyone since the feature is new)