fix(core/protocols): make error namespace removal unconditional in JSON RPC#8031
Merged
Conversation
siddsriv
approved these changes
May 18, 2026
4311849 to
32876af
Compare
32876af to
84decaf
Compare
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
V2218690158
Description
This updates the error identification logic in AWS JSON RPC 1.0 to discard the namespace, which is required when services return errors that have different ids than the service model.
See https://smithy.io/2.0/aws/protocols/aws-json-1_0-protocol.html#operation-error-serialization
For example, DynamoDB has one error which appears as:
com.amazonaws.dynamodb.v20120810#ConditionalCheckFailedExceptioncom.amazonaws.dynamodb#ConditionalCheckFailedExceptionWithout this fix, a bug introduced in https://www.npmjs.com/package/@aws-sdk/core/v/3.974.9 through https://www.npmjs.com/package/@aws-sdk/core/v/3.974.11 causes
error instanceof ConditionalCheckFailedExceptionand similar patternedinstanceofchecks to fail to returntruewhen they are supposed to.AWS JSON 1.0 is an RPC protocol used by the following services:
Testing
added integration test
Checklist
*.integ.spec.ts) or E2E tests.@public,@internaltags and enabled doc generation on the package. Remember that access level annotations go below the description, not above.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.